Re: Fix for failing tests on Solaris

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Apr 29, 2022, 16:09 UTC
Message-ID: <20220429160913.wogvmyxosctdlosz@carlos-mbp.lan>
In-Reply-To: <20220429062337.bcpjizaujjmw65dt@virtual.cz.oracle.com>

On Fri, Apr 29, 2022 at 08:23:37AM +0200, Vladimir Marek wrote:

> 
> That paths contain posix conformant binaries, but the tests do expect
> Linux-like behaving binaries.

Expecting Linux-like behaviour is indeed not what the tests should be doing, so correcting that might ALSO help other people that don't have an alternative GNU implementation available IMHO

So detailing those failures and fixing them might be preferable (even if likely more difficult)

Show 8 quoted lines

> --- git-2.35.1/config.mak.uname
> +++ git-2.35.1/config.mak.uname
> @@ -162,7 +162,7 @@ ifeq ($(uname_S),SunOS)
>         NEEDS_SOCKET = YesPlease
>         NEEDS_NSL = YesPlease
>         SHELL_PATH = /bin/bash
> -       SANE_TOOL_PATH = /usr/xpg6/bin:/usr/xpg4/bin
> +       SANE_TOOL_PATH = /usr/gnu/bin

I haven't used Solaris for a while (since around OpenSolaris Indiana development stopped), but wouldn't this break in Solaris 10 and older?

> Makes all tests but t7812 pass successfully. t7812 fails on locales and
> utf-8 which do behave differently in Solaris.

And additional fix for that (since you seem to have access to a fresh Solaris 11.4 installation at least), would be forthcomming.

Wondering also if there is a way to plug one of those from Oracle Cloud through a GitHub actions so we could prevent future issues by including Solaris in our CI runs.

Carlo