Fix for failing tests on Solaris

From: Vladimir Marek <vladimir.marek@oracle.com>
Date: Apr 29, 2022, 06:23 UTC
Message-ID: <20220429062337.bcpjizaujjmw65dt@virtual.cz.oracle.com>

Hello,

Sorry if this is not the best way to report issues.

Solaris ships git[1]. We run it's test suite and we were having multiple failures[2]. I noticed that the tests do expect binaries to be found in [3]:

SANE_TOOL_PATH = /usr/xpg6/bin:/usr/xpg4/bin

That paths contain posix conformant binaries, but the tests do expect Linux-like behaving binaries.

The patch I am about to apply to git

--- git-2.35.1/config.mak.uname +++ git-2.35.1/config.mak.uname

@@ -162,7 +162,7 @@ ifeq ($(uname_S),SunOS)
        NEEDS_SOCKET = YesPlease
        NEEDS_NSL = YesPlease
        SHELL_PATH = /bin/bash
-       SANE_TOOL_PATH = /usr/xpg6/bin:/usr/xpg4/bin
+       SANE_TOOL_PATH = /usr/gnu/bin
        HAVE_ALLOCA_H = YesPlease
        NO_STRCASESTR = YesPlease
        NO_MEMMEM = YesPlease

Makes all tests but t7812 pass successfully. t7812 fails on locales and
utf-8 which do behave differently in Solaris.

I would suggest to update the tests to use /usr/gnu/bin path.

[1] https://github.com/oracle/solaris-userland/tree/master/components/git
[2] https://github.com/oracle/solaris-userland/tree/master/components/git/test
[3] https://github.com/git/git/blob/master/config.mak.uname#L176

Thank you

-- 
	Vlad