Re: [PATCH v2.5 02/11] bundle: verify using connected()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 24, 2023, 20:41 UTC
- Message-ID
- <xmqqr0vjfyxf.fsf@gitster.g>
- In-Reply-To
- <bad5d998-b34a-15dd-4f9d-9bf1cb74dda0@github.com>
Derrick Stolee <derrickstolee@github.com> writes:
Show 8 quoted lines
>> I do not see the need to say "even" here. In what other situation >> do we make connectivity checks, and is there a need to be more >> strict than others when checking fetched packfiles? > > I suppose that I was implying that fetches are the more common > operation, and the scrutiny applied to an arbitrary pack-file from > a remote is probably higher there. However, who knows where a > bundle came from, so the scrutiny should be the same.
Ah, I see that is where that "even" came from. And yes, I agree that unbundling and fetch should be suspicious of their input to the same degree.