Re: [PATCH v2 10/10] bundle-uri: test missing bundles with heuristic

From: Derrick Stolee <derrickstolee@github.com>
Date: Jan 30, 2023, 18:47 UTC
Message-ID: <d93aff7f-2fcb-1d4d-4537-c23ea7171215@github.com>
In-Reply-To: <b3f2992d-f614-5cc7-f606-d3607a154685@github.com>

On 1/27/2023 2:21 PM, Victoria Dye wrote:

> Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <derrickstolee@github.com>

Show 12 quoted lines

>> +	# Only base bundle unbundled.
>> +	git -C download-2 for-each-ref --format="%(refname)" "refs/bundles/*" >refs &&
>> +	cat >expect <<-EOF &&
>> +	refs/bundles/base
>> +	refs/bundles/right
>> +	EOF
>> +	test_cmp expect refs &&
> 
> Maybe I'm misreading, but I don't think the comment ("Only base bundle
> unbundled") lines up with the expected bundle refs (both bundle-1
> ('refs/bundles/base') and bundle-3 ('refs/bundles/right') seem to be
> unbundled).

Show 13 quoted lines

>> +	# All bundles failed to unbundle
>> +	git -C download-3 for-each-ref --format="%(refname)" "refs/bundles/*" >refs &&
>> +	cat >expect <<-EOF &&
>> +	refs/bundles/base
>> +	refs/bundles/left
>> +	refs/bundles/right
>> +	EOF
>> +	test_cmp expect refs
> 
> Similar issue with the comment here - it says that all bundles *failed* to
> unbundle, but the test case description ("Case 3: top bundle does not exist,
> rest unbundle fine.") and the result show bundle-1, bundle-2, and bundle-3
> all unbundling successfully.

Thank you for reading carefully. I'm sorry about not updating the comments after copying these checks around the test file.

Thanks, -Stolee