Re: [PATCH 6/8] bundle-uri: drop bundle.flag from design doc
Derrick Stolee via GitGitGadget wrote:
Show 8 quoted lines
> From: Derrick Stolee <derrickstolee@github.com>
>
> The Implementation Plan section lists a 'bundle.flag' option that is not
> documented anywhere else. What is documented elsewhere in the document
> and implemented by previous changes is the 'bundle.heuristic' config
> key. For now, a heuristic is required to indicate that a bundle list is
> organized for use during 'git fetch', and it is also sufficient for all
> existing designs.
Good catch, thanks for keeping the documentation consistent!
Show 29 quoted lines
>
> Signed-off-by: Derrick Stolee <derrickstolee@github.com>
> ---
> Documentation/technical/bundle-uri.txt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/technical/bundle-uri.txt b/Documentation/technical/bundle-uri.txt
> index b78d01d9adf..91d3a13e327 100644
> --- a/Documentation/technical/bundle-uri.txt
> +++ b/Documentation/technical/bundle-uri.txt
> @@ -479,14 +479,14 @@ outline for submitting these features:
> (This choice is an opt-in via a config option and a command-line
> option.)
>
> -4. Allow the client to understand the `bundle.flag=forFetch` configuration
> +4. Allow the client to understand the `bundle.heuristic` configuration key
> and the `bundle.<id>.creationToken` heuristic. When `git clone`
> - discovers a bundle URI with `bundle.flag=forFetch`, it configures the
> - client repository to check that bundle URI during later `git fetch <remote>`
> + discovers a bundle URI with `bundle.heuristic`, it configures the client
> + repository to check that bundle URI during later `git fetch <remote>`
> commands.
>
> 5. Allow clients to discover bundle URIs during `git fetch` and configure
> - a bundle URI for later fetches if `bundle.flag=forFetch`.
> + a bundle URI for later fetches if `bundle.heuristic` is set.
>
> 6. Implement the "inspect headers" heuristic to reduce data downloads when
> the `bundle.<id>.creationToken` heuristic is not available.