Re: [PATCH 2/4] doc: update links to current pages
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 22, 2023, 22:23 UTC
- Message-ID
- <xmqqr0mpyhi6.fsf@gitster.g>
- In-Reply-To
- <f9f3f4af1c8889eb69f777a322348afc53feeca2.1695392028.git.gitgitgadget@gmail.com>
"Josh Soref via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 24 quoted lines
> From: Josh Soref <jsoref@gmail.com> > > Signed-off-by: Josh Soref <jsoref@gmail.com> > --- > Documentation/CodingGuidelines | 2 +- > Documentation/RelNotes/1.6.2.txt | 2 +- > Documentation/RelNotes/1.6.3.txt | 2 +- > Documentation/RelNotes/1.6.4.txt | 2 +- > Documentation/RelNotes/1.6.5.txt | 2 +- > Documentation/RelNotes/1.6.6.txt | 2 +- > Documentation/git-cvsimport.txt | 2 +- > Documentation/git-format-patch.txt | 2 +- > Documentation/git-ls-remote.txt | 4 ++-- > Documentation/git.txt | 2 +- > Documentation/gitcore-tutorial.txt | 4 ++-- > compat/nedmalloc/malloc.c.h | 2 +- > contrib/persistent-https/README | 2 +- > git-gui/git-gui.sh | 2 +- > gitk-git/gitk | 2 +- > gitweb/static/js/lib/common-lib.js | 2 +- > http.c | 2 +- > imap-send.c | 2 +- > json-writer.h | 2 +- > 19 files changed, 21 insertions(+), 21 deletions(-)
Broken links are annoying while reading documentation. Thank you for doing the necessary research.
I am not sure if direct replacement to Release Notes (historical document) is the best way to present these updates, but let's assume it is OK for now.
Show 13 quoted lines
> diff --git a/Documentation/git-ls-remote.txt b/Documentation/git-ls-remote.txt > index 1c4f696ab57..b9c8478a62a 100644 > --- a/Documentation/git-ls-remote.txt > +++ b/Documentation/git-ls-remote.txt > @@ -128,7 +128,7 @@ d4ca2e3147b409459955613c152220f4db848ee1 refs/tags/v2.40.0 > * List all references matching given patterns: > + > ---- > -$ git ls-remote http://www.kernel.org/pub/scm/git/git.git master seen rc > +$ git ls-remote https://git.kernel.org/pub/scm/git/git.git master seen rc > 5fe978a5381f1fbad26a80e682ddd2a401966740 refs/heads/master > c781a84b5204fb294c9ccc79f8b3baceeb32c061 refs/heads/seen > ----
I am not sure if this change is warranted. The old URL still works just fine, even though there are no refs that match "rc" and the "master" branch is no longer at 5fe978a5, but these are not problem caused by using the http:// address. The point of the example is not about preferred use of HTTP:// over HTTPS://, so this again falls into "if we were writing this anew, we may have used the other address, but the original still works, so it is not worth the patch noise" category, I would think.
Show 12 quoted lines
> diff --git a/Documentation/gitcore-tutorial.txt b/Documentation/gitcore-tutorial.txt > index 2122aeb9769..924a9a97807 100644 > --- a/Documentation/gitcore-tutorial.txt > +++ b/Documentation/gitcore-tutorial.txt > @@ -1101,8 +1101,8 @@ Examples. > > the above are equivalent to: > > -. `git pull http://www.kernel.org/pub/scm/git/git.git/ HEAD` > -. `git pull http://www.kernel.org/pub/scm/git/git.git/ tag v0.99.1` > +. `git pull https://git.kernel.org/pub/scm/git/git.git/ HEAD` > +. `git pull https://git.kernel.org/pub/scm/git/git.git/ tag v0.99.1`
Likewise.
Show 11 quoted lines
> diff --git a/Documentation/git.txt b/Documentation/git.txt > index 11228956cd5..c7292eb25d0 100644 > --- a/Documentation/git.txt > +++ b/Documentation/git.txt > @@ -1061,7 +1061,7 @@ Authors > ------- > Git was started by Linus Torvalds, and is currently maintained by Junio > C Hamano. Numerous contributions have come from the Git mailing list > -<git@vger.kernel.org>. http://www.openhub.net/p/git/contributors/summary > +<git@vger.kernel.org>. https://openhub.net/p/git/contributors/summary > gives you a more complete list of contributors.
OK, even though the former seems to redirect to the latter, so in that sense it is still "current".
Show 10 quoted lines
> diff --git a/compat/nedmalloc/malloc.c.h b/compat/nedmalloc/malloc.c.h > index 5c5357a379f..4b711c6b9ca 100644 > --- a/compat/nedmalloc/malloc.c.h > +++ b/compat/nedmalloc/malloc.c.h > @@ -1359,7 +1359,7 @@ LONG __cdecl _InterlockedExchange(LONG volatile *Target, LONG Value); > /* --[ start GCC compatibility ]---------------------------------------------- > * Compatibility <intrin_x86.h> header for GCC -- GCC equivalents of intrinsic > * Microsoft Visual C++ functions. Originally developed for the ReactOS > - * (<http://www.reactos.org/>) and TinyKrnl (<http://www.tinykrnl.org/>) > + * (<https://reactos.org/>) and TinyKrnl (<http://www.tinykrnl.org/>)
Likewise for reactos; the tinykrnl one does not seem to be current.
In any case, this is borrowed code, so I'd rather not touch it and risk giving a wrong page that is not a replacement.
Show 10 quoted lines
> diff --git a/contrib/persistent-https/README b/contrib/persistent-https/README > index 2ad95893c27..2c9bec91066 100644 > --- a/contrib/persistent-https/README > +++ b/contrib/persistent-https/README > @@ -60,7 +60,7 @@ https://kernel.googlesource.com/pub/scm/git/git > > PREREQUISITES > > -The code is written in Go (http://golang.org/) and the Go compiler is > +The code is written in Go (https://go.dev/) and the Go compiler is
Likewise.
> required. Currently, the compiler must be built and installed from tip > of source, in order to include a fix in the reverse http proxy: > https://code.google.com/p/go/source/detail?r=a615b796570a2cd8591884767a7d67ede74f6648
This is an interesting one. code.google.com is no longer there and the updated URL seems to be at https://github.com/golang/go somewhere.