Re: [PATCH v2 1/4] doc: switch links to https
- From
Josh Soref <jsoref@gmail.com>
- Date
- Nov 24, 2023, 03:12 UTC
- Message-ID
- <CACZqfqD-M3NAb3=Y-StWfAk50r-XPkFRRLLJPe9RUek21+Lnsg@mail.gmail.com>
- In-Reply-To
- <CABPp-BEbfsss39-cENw2BwnQPp4edp9_JSN_O1e7vcci9XE+cQ@mail.gmail.com>
Elijah Newren wrote:
Show 5 quoted lines
> > -For example, at the time this page was written, the http://repo.or.cz[] > > +For example, at the time this page was written, the https://repo.or.cz[] > > Given the "at the time this page was written" comment, I'm not sure we > should switch to https here.
I claim that it refers to the file that is presented to the user, which is current as of the time it was delivered by the specific version of the git package.
Show 7 quoted lines
> > -See http://repo.or.cz/w/git.git/tree/HEAD:/gitweb/[] for gitweb source code, > > +See https://repo.or.cz/w/git.git/tree/HEAD:/gitweb/[] for gitweb source code, > > browsed using gitweb itself. > > The suggested link gives a "404 - No such tree". Granted, the http: > link also does that, but it'd be nicer to provide a non-broken link, > which you can do by stripping the '/[]' from the end of the URL.
The `[]` is part of AsciiDoc's [1] notation. I tripped on this when I first looked into this series (as I'm much more familiar w/ Markdown and Restructured Text).
[1] https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/