Re: [PATCH v2 2/2] for-each-repo: work correctly in a worktree
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 10 quoted lines
>>> * Note that the following options are not in local_repo_env:
>>> * - EXEC_PATH_ENVIRONMENT persists --exec-path option.
>>> */
>>> if (strncmp(local_repo_env[i], "CONFIG_", 7) &&
>>
>> Minor nit: !starts_with() lets you avoid counting bytes yourself and
>> hardcoding "7" here.
>
> More seriously it should be looking for strings starting with
> "GIT_CONFIG_", not the name of the preprocessor definitions.
Thanks. I missed that completely.