Re: [PATCH v2 2/2] for-each-repo: work correctly in a worktree
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Feb 27, 2026, 22:28 UTC
- Message-ID
- <3d574b51-78e2-4850-81dc-5c55b9562c02@gmail.com>
- In-Reply-To
- <xmqqqzq6otx7.fsf@gitster.g>
On 2/27/26 2:41 PM, Junio C Hamano wrote:
Show 14 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes: > >>>> * Note that the following options are not in local_repo_env: >>>> * - EXEC_PATH_ENVIRONMENT persists --exec-path option. >>>> */ >>>> if (strncmp(local_repo_env[i], "CONFIG_", 7) && >>> >>> Minor nit: !starts_with() lets you avoid counting bytes yourself and >>> hardcoding "7" here. >> >> More seriously it should be looking for strings starting with >> "GIT_CONFIG_", not the name of the preprocessor definitions. > > Thanks. I missed that completely.
Same! And I will try to find a way to test these things to ensure these mistakes are not prevented only by careful code reviewers!
Thanks, -Stolee