Re: [PATCH v2 0/8] repack: various corner cases for cruft-less MIDXs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 4, 2026, 22:48 UTC
- Message-ID
- <xmqqqzh0z00d.fsf@gitster.g>
- In-Reply-To
- <xmqqse1o4g8t.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> Taylor Blau <ttaylorr@openai.com> writes: > >> On Tue, Oct 27, 2026 at 05:27:02PM -0700, Junio C Hamano wrote: >>> Taylor Blau <ttaylorr@openai.com> writes: >>> >>> > This is a reroll of [1]. Thanks to Stolee, Junio, and Peff for >>> > reviewing. >>> > ... >>> > Thanks in advance for your review! >>> >>> I am trying to eject stale topics out of my tree, and the discussion >>> on this topic is about to pass the 1-month mark. It seems that >>> comments on half of them are "looks good" and the rest are "just as >>> confusing as the original without improvement". How viable is this >>> topic? Are we still improving on it, or has it long passed the >>> point of diminishing returns that nobody is interested in polishing >>> it any longer? >> >> This one should be ready to go as-is! >> >> Thanks, >> Taylor > > Hmph, the question was not meant to be answered by the author, > though ;-)
OK, so I bit the bullet and read the patches and their existing review discussions again myself. I too were confused by pretty much the same things Peff commented on being confusing X-<, but I do not have concrete improvement ideas to offer right now.