On Wed, Sep 30, 2026 at 10:42:10AM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> We used to take _data that is rev_info, but no longer. We lost decl
> for "struct rev_info *revs" and rewrote its only use to directly
> reference ctx->revs. As long as the result compiles, we know there
> is no stray reference to "revs" left in this function, so the
> rewrite is complete. It is rare but I love this kind of patch whose
> correctness can be seen without reading beyond the context ;-)
;-)
> It is not clear to me what the implication of assuming a non-NULL
> 'ctx' always means a non-NULL 'ctx->revs' is for the code health in
> the longer term, though.
That's fair. For the following round, I added a small note next to the 'revs' member in the struct's definition to indicate that it must be non-NULL.
Taylor Blau <ttaylorr@openai.com>