Re: [PATCH 3/4] repack: retain cruft packs in MIDXs after incremental repacks

From: Taylor Blau <ttaylorr@openai.com>
Date: Oct 1, 2026, 03:21 UTC
Message-ID: <ar3Rxga-GXTvcvFH@com-79390>
In-Reply-To: <20260930204529.GB747209@coredump.intra.peff.net>

On Wed, Sep 30, 2026 at 04:45:29PM -0400, Jeff King wrote:

> That's not a new problem, but just a spot where the fix doesn't extend.
> Not sure how important it is to do now, or if it can wait for future
> work.

Yeah, good point. I have a fix for it in the subsequent round, though it did make the overall series longer to accommodate predatory patches that make the substantive ones easier to grok.

I think that the result is sound, hence its inclusion in v2. I briefly considered dropping that part of this series altogether to deal with it another day. But doing so felt irresponsible as the earlier round pointed out the existence of a bug, the subsequent round should not ignore it.

On the other hand, as you note, it's not a new problem relative to this series, and so perhaps leaving it out wouldn't have been so bad. But I think all thing equal, the patches exist, and I think that they are sound, so I figured that I'd send them in the following round for completeness.

The maintainer should however, feel free to avoid queueing that part of the series if we want to punt on it for now.

Thanks, Taylor