Re: [PATCH 2/4] pack-objects: ensure tree/tag closure with '--stdin-packs=follow' On Wed, Sep 30, 2026 at 02:16:53PM -0400, Derrick Stolee wrote: Show 10 quoted lines > > @@ -3807,6 +3807,7 @@ static int stdin_packs_hints_nr;
> > struct stdin_packs_context {
> > struct rev_info *revs;
> > enum stdin_packs_mode mode;
> > + struct oid_array extra_roots;
>
> I believe this should be an oidset to avoid adding duplicate objects
> that appear multiple times. The order of these extra roots doesn't
> matter (such as in a --topo-order walk). We only care about the
> binary "reachable or not?" question. Great suggestion! I adjusted it in the following round. Thanks, Taylor
Message 14 of 41 in “repack: various corner cases for cruft-less MIDXs” 0/4 repack: various corner cases for cruft-less MIDXsTaylor Blau, Sep 30, 2026 1/4 pack-objects: introduce `stdin_packs_context` structTaylor Blau, Sep 30, 2026 2/4 pack-objects: ensure tree/tag closure with '--stdin-packs=follow'Taylor Blau, Sep 30, 2026 3/4 repack: retain cruft packs in MIDXs after incremental repacksTaylor Blau, Sep 30, 2026 4/4 repack: retain cruft packs in MIDXs containing kept packsTaylor Blau, Sep 30, 2026 Junio C Hamano Sep 30, 2026 Junio C Hamano Sep 30, 2026 Derrick Stolee Sep 30, 2026 Jeff King Sep 30, 2026 Jeff King Sep 30, 2026 Jeff King Sep 30, 2026 Jeff King Sep 30, 2026 Taylor Blau Oct 1, 2026 Taylor Blau Oct 1, 2026 Taylor Blau Oct 1, 2026 Taylor Blau Oct 1, 2026 Taylor Blau Oct 1, 2026 Taylor Blau Oct 1, 2026 0/8 repack: various corner cases for cruft-less MIDXsTaylor Blau, Oct 1, 2026 1/8 pack-objects: introduce `stdin_packs_context` structTaylor Blau, Oct 1, 2026 2/8 pack-objects: ensure tree/tag closure with '--stdin-packs=follow'Taylor Blau, Oct 1, 2026 3/8 repack: retain cruft packs in MIDXs after incremental repacksTaylor Blau, Oct 1, 2026 4/8 repack: use a sorted list for explicitly kept packsTaylor Blau, Oct 1, 2026 5/8 repack: follow kept packs when omitting cruft from the MIDXTaylor Blau, Oct 1, 2026 6/8 repack: track the preferred pack explicitly in MIDX write stepsTaylor Blau, Oct 1, 2026 7/8 repack: defer allocating the append plan's write stepTaylor Blau, Oct 1, 2026 8/8 repack: include required packs in incremental MIDX writesTaylor Blau, Oct 1, 2026 Elijah Newren Oct 1, 2026 Taylor Blau Oct 2, 2026 Jeff King Oct 2, 2026 Jeff King Oct 2, 2026 Jeff King Oct 2, 2026 Jeff King Oct 2, 2026 Jeff King Oct 2, 2026 Jeff King Oct 2, 2026 Taylor Blau Oct 3, 2026 Taylor Blau Oct 3, 2026 Taylor Blau Oct 3, 2026 Taylor Blau Oct 3, 2026 Jeff King Oct 3, 2026 Jeff King Oct 3, 2026 Read the whole thread , see it on lore , or plain text .