git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: do not lose SQUASH_MSG contents

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 14, 2016, 18:19 UTC
Message-ID
<xmqqpouwapnd.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<56E5B3F9.6070404@cs-ware.de>
Sven Strickroth <sven@cs-ware.de> writes:
Show 13 quoted lines
> When concluding a conflicted "git merge --squash", the command
> failed to read SQUASH_MSG that was prepared by "git merge", and
> showed only the "# Conflicts:" list of conflicted paths.
>
> Place the contents from SQUASH_MSG at the beginning, just like we
> show the commit log skeleton first when concluding a normal merge,
> and then show the "# Conflicts:" list, to help the user write the
> log message for the resulting commit.
>
> Signed-off-by: Sven Strickroth <sven@cs-ware.de>
> ---
>  builtin/commit.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

The updated code looks good to me; sorry for misleading you with fuzzy comments earlier.

We may want to have a test to prevent this from getting broken in the future updates.

Show 24 quoted lines
> diff --git a/builtin/commit.c b/builtin/commit.c
> index d054f84..d40b788 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -726,9 +726,18 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
>  				      &sb, &ctx);
>  		hook_arg1 = "message";
>  	} else if (!stat(git_path_merge_msg(), &statbuf)) {
> +		/*
> +		 * prepend SQUASH_MSG here if it exists and a
> +		 * "merge --squash" was originally performed
> +		*/
> +		if (!stat(git_path_squash_msg(), &statbuf)) {
> +			if (strbuf_read_file(&sb, git_path_squash_msg(), 0) < 0)
> +				die_errno(_("could not read SQUASH_MSG"));
> +			hook_arg1 = "squash";
> +		} else
> +			hook_arg1 = "merge";
>  		if (strbuf_read_file(&sb, git_path_merge_msg(), 0) < 0)
>  			die_errno(_("could not read MERGE_MSG"));
> -		hook_arg1 = "merge";
>  	} else if (!stat(git_path_squash_msg(), &statbuf)) {
>  		if (strbuf_read_file(&sb, git_path_squash_msg(), 0) < 0)
>  			die_errno(_("could not read SQUASH_MSG"));
Previous: Sven StrickrothNext: Junio C Hamano
Message 10 of 13 in “Commit message not helpful after merge squash with conflicts”
  1. Sven StrickrothMar 5, 2016
  2. Also read SQUASH_MSG if a conflict on a merge squash occurredSven Strickroth, Mar 8, 2016
  3. Junio C HamanoMar 8, 2016
  4. Sven StrickrothMar 8, 2016
  5. Junio C HamanoMar 8, 2016
  6. commit: do not lose SQUASH_MSG contentsSven Strickroth, Mar 8, 2016
  7. Junio C HamanoMar 9, 2016
  8. Junio C HamanoMar 9, 2016
  9. commit: do not lose SQUASH_MSG contentsSven Strickroth, Mar 13, 2016
  10. Junio C HamanoMar 14, 2016
  11. Junio C HamanoMar 14, 2016
  12. commit: do not lose SQUASH_MSG contentsSven Strickroth, Mar 21, 2016
  13. Junio C HamanoMar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.