git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Also read SQUASH_MSG if a conflict on a merge squash occurred

From
SSSven Strickroth <sven@cs-ware.de>
Date
Mar 8, 2016, 04:17 UTC
Message-ID
<56DE5272.2080009@cs-ware.de>
In-Reply-To
<56DAB71E.6000509@cs-ware.de>

After a merge --squash with a conflict the commit message did not contain the information about the squashed commits, but only the "# Conflicts:" information.

Signed-off-by: Sven Strickroth <sven@cs-ware.de>
---
 builtin/commit.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/builtin/commit.c b/builtin/commit.c
index d054f84..0405d68 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -729,6 +729,12 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
 		if (strbuf_read_file(&sb, git_path_merge_msg(), 0) < 0)
 			die_errno(_("could not read MERGE_MSG"));
 		hook_arg1 = "merge";
+		/* append SQUASH_MSG here if it exists and a merge --squash was originally performed */
+		if (!stat(git_path_squash_msg(), &statbuf)) {
+			if (strbuf_read_file(&sb, git_path_squash_msg(), 0) < 0)
+				die_errno(_("could not read SQUASH_MSG"));
+			hook_arg1 = "squash";
+		}
 	} else if (!stat(git_path_squash_msg(), &statbuf)) {
 		if (strbuf_read_file(&sb, git_path_squash_msg(), 0) < 0)
 			die_errno(_("could not read SQUASH_MSG"));
-- 
Best regards,
 Sven Strickroth
 PGP key id F5A9D4C4 @ any key-server
Previous: Sven StrickrothNext: Junio C Hamano
Message 2 of 13 in “Commit message not helpful after merge squash with conflicts”
  1. Sven StrickrothMar 5, 2016
  2. Also read SQUASH_MSG if a conflict on a merge squash occurredSven Strickroth, Mar 8, 2016
  3. Junio C HamanoMar 8, 2016
  4. Sven StrickrothMar 8, 2016
  5. Junio C HamanoMar 8, 2016
  6. commit: do not lose SQUASH_MSG contentsSven Strickroth, Mar 8, 2016
  7. Junio C HamanoMar 9, 2016
  8. Junio C HamanoMar 9, 2016
  9. commit: do not lose SQUASH_MSG contentsSven Strickroth, Mar 13, 2016
  10. Junio C HamanoMar 14, 2016
  11. Junio C HamanoMar 14, 2016
  12. commit: do not lose SQUASH_MSG contentsSven Strickroth, Mar 21, 2016
  13. Junio C HamanoMar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.