Re: [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 12, 2019, 00:32 UTC
- Message-ID
- <xmqqpnrxg823.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190212002705.GD13301@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> Hmm. We care to _some_ degree, since that's the condition we set up for > making sure that update-ref cannot take the lock. But it would probably > be fine to just confirm that we failed to take the lock. And there, > checking for just "Unable to create $Q.*packed-refs.lock" would be > sufficient.
Yeah, that was what I was getting at. On top, we could also see "test -e" after noticing the failure but that probably does not help us prove anything.