git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case

From
Jeff King <peff@peff.net>
Date
Feb 12, 2019, 00:27 UTC
Message-ID
<20190212002705.GD13301@sigill.intra.peff.net>
In-Reply-To
<xmqqftsughks.fsf@gitster-ct.c.googlers.com>
On Mon, Feb 11, 2019 at 01:07:15PM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> >> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err
> >
> > The message does not match, does it? Here we grep for "File exists"
> > but the message you showed says "File already exists".
> 
> Hmph, this is from strerror(), right?
> 
> The question is if we should be using grep to match on strerror()
> result in the C locale.

Yeah, I agree that's questionable. And I'm mildly surprised it hasn't been a problem before now.

> Do we really care that the reason of the
> failure is due to EEXIST for this particular test?

Hmm. We care to _some_ degree, since that's the condition we set up for making sure that update-ref cannot take the lock. But it would probably be fine to just confirm that we failed to take the lock. And there, checking for just "Unable to create $Q.*packed-refs.lock" would be sufficient.

-Peff
Previous: Randall S. BeckerNext: Junio C Hamano
Message 6 of 13 in “[Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case”
  1. Randall S. BeckerFeb 10, 2019
  2. Duy NguyenFeb 11, 2019
  3. Randall S. BeckerFeb 11, 2019
  4. Junio C HamanoFeb 11, 2019
  5. Randall S. BeckerFeb 11, 2019
  6. Jeff KingFeb 12, 2019
  7. Junio C HamanoFeb 12, 2019
  8. Jeff KingFeb 12, 2019
  9. Re* [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one caseJunio C Hamano, Feb 14, 2019
  10. Randall S. BeckerFeb 14, 2019
  11. Junio C HamanoFeb 14, 2019
  12. Martin ÅgrenFeb 15, 2019
  13. Junio C HamanoFeb 15, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.