Re: [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 11, 2019, 09:56 UTC
Message-ID: <CACsJy8Bn+2zY6y_QqCjbB3qWM-F=3d0H5vgWj4az=md2FZ8RhA@mail.gmail.com>
In-Reply-To: <000801d4c174$05b76860$11263920$@nexbridge.com>

On Mon, Feb 11, 2019 at 2:09 AM Randall S. Becker <rsbecker@nexbridge.com> wrote:

Show 6 quoted lines

>
> Hi All,
>
> I tracked down a breakage in t1404 subtest 52. The line
>
> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err

The message does not match, does it? Here we grep for "File exists" but the message you showed says "File already exists".

Show 38 quoted lines

> is correctly working, but is reporting a completion 1.
>
> The verbose output, with diagnostics, is:
>
> error: 'grep Unable to create '.*packed-refs.lock': File exists err' didn't
> find a match in:
> error: Unable to create '/home/git/git/t/trash
> directory.t1404-update-ref-errors/.git/packed-refs.lock': File already
> exists.
>
> Another git process seems to be running in this repository, e.g.
> an editor opened by 'git commit'. Please make sure all processes
> are terminated then try again. If it still fails, a git process
> may have crashed in this repository earlier:
> remove the file manually to continue.
>
> Reported 1 from test_i18ngrep
>
> err contains (without the double quotes):
> "error: Unable to create '/home/git/git/t/trash
> directory.t1404-update-ref-errors/.git/packed-refs.lock': File already
> exists.
>
> Another git process seems to be running in this repository, e.g.
> an editor opened by 'git commit'. Please make sure all processes
> are terminated then try again. If it still fails, a git process
> may have crashed in this repository earlier:
> remove the file manually to continue."
>
> Which means that
>
> ! test_have_prereq C_LOCALE_OUTPUT || test_cmp "$@"
>
> is completing with a 1. Is that the intent? Any clues?
>
> Thanks,
> Randall
>

-- 
Duy