Re: [PATCH v5 0/2] documentation: add lab for first contribution
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 8, 2019, 03:30 UTC
- Message-ID
- <xmqqpnotipww.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190507213040.151799-1-emilyshaffer@google.com>
Emily Shaffer <emilyshaffer@google.com> writes:
> - Removed 'extern' from the addition to builtin.h
I said something that conflicts with this in my message to JTan, but I am fine with this removal of extern, as it is reasonable that Denton Liu's no-extern work would land soonish.
I agree with the spirit of all the other points listed in the cover letter as well. Thanks for working on this.