[PATCH v5 0/2] documentation: add lab for first contribution
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- May 7, 2019, 21:30 UTC
- Message-ID
- <20190507213040.151799-1-emilyshaffer@google.com>
- In-Reply-To
- <20190423193410.101803-1-emilyshaffer@google.com>
Since v4, I've made one major change and a handful of minor changes. The major change is contained entirely in patch 2/2; patch 1/2 has only nit fixes compared to v4.
Major: - I've added anchors to each section. These anchors are custom-named in order to be compatible with asciidoc as well as asciidoctor. I figured it would be easier to review the naming choices if the anchors stood alone from the main introductory patch.
Minor: - Alphabetized Documentation/Makefile - Fixup headers - a few renames for clarity, casing, and a missed monospace, based on Phil Hord & Jonathan Tan comments. - Removed 'extern' from the addition to builtin.h - Replace "cheating off" with "mimicking" in a few places - Clarify instructions for writing commit message to remove ambiguity and include requirement for newline after subject - Remove unnecessary explanation of `git commit --amend` - Remove braces to bring code sample into Git style - Typo, word-reversal, and early line break fixes - Add neglected argument to `git send-email` samples to actually include patches
Emily Shaffer (2): documentation: add tutorial for first contribution documentation: add anchors to MyFirstContribution
Documentation/Makefile | 1 + Documentation/MyFirstContribution.txt | 1110 +++++++++++++++++++++++++ 2 files changed, 1111 insertions(+) create mode 100644 Documentation/MyFirstContribution.txt
-- 2.21.0.1020.gf2820cf01a-goog