Re: [PATCH v5 1/2] documentation: add tutorial for first contribution

From: Junio C Hamano <gitster@pobox.com>
Date: May 8, 2019, 03:46 UTC
Message-ID: <xmqqimulip5k.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190507213040.151799-2-emilyshaffer@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 5 quoted lines

> +=== Clone the Git Repository
> +
> +Git is mirrored in a number of locations. Clone the repository from one of them;
> +https://git-scm.com/downloads suggests one of the best places to clone from is
> +the official mirror on GitHub.

I didn't want to have to get into fine-grained wordsmithing (let alone bikeshedding) this late in the iteration of the topic, but "the official mirror" is not something anybody suggested in the recent reviews (JTan's rephrasing, which I already said that I am OK with, said something like "one of the many mirrors").

And "official" is a phrase I have trouble with in this context. A mirror does not have to be blessed as official; that's the point of a mirror---anybody can make one to help users with better connectivity or availability, as long as its users trust the mirror maintainer for mirror's correctness and freshness.

So perhaps "... clone from is the mirror maintained by GitHub folks" or just simply "is the mirror on GitHub"?

> +$ git send-email --to=target@example.com
> +		 --in-reply-to="<foo.12345.author@example.com>"

Very nice attention to the detail here. I like it (the earlier round did not have dq around the message ID).

> +		 psuh/v2*
> +----

All other edits relative to the previous round look very sensible to me. Thanks.