Re: [PATCH 0/1] documentation: add lab for first contribution
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Apr 12, 2019, 22:58 UTC
- Message-ID
- <CAJoAoZnGAS5DOJoU_y+1t20kyxsDodFpQmwRd2_XZD9S2=pRLQ@mail.gmail.com>
- In-Reply-To
- <xmqqmukwymq7.fsf@gitster-ct.c.googlers.com>
On Thu, Apr 11, 2019 at 7:35 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> > "Emily Shaffer via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > RFC. I am still working on adding a section on handling refs and objects. > > Thanks. Is 'lab' understood widely enough? I _think_ you are > abbreviating what is known as 'codelab' by your colleagues at work, > but would it make it more in line with what we already have in this > project, perhaps, to call it a "tutorial"? >
I think you're right; I'll try to modify throughout. As part of that change I will also move the sample to a branch with a more descriptive name and change the URL.
Thanks a lot for the detailed review, Junio. I expect to send a new patch later today, including an exercise in examining a specific commit.
-- Emily Shaffer