Re: [PATCH v3 00/11] Advertise session ID in protocol capabilities

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2020, 22:08 UTC
Message-ID: <xmqqpn41ccor.fsf@gitster.c.googlers.com>
In-Reply-To: <cover.1605136908.git.steadmon@google.com>

Josh Steadmon <steadmon@google.com> writes:

Show 19 quoted lines

> In order to more easily debug remote operations, it is useful to be able
> to identify sessions on either side of the connection. This series
> allows clients and servers to provide a unique session ID via a new
> "session-id" protocol capability. This session ID can be logged on each
> side of the connection, allowing logs to be joined during debugging
> sessions.
>
> Changes from V2:
> * De-emphasize connection to trace2
> * Renamed capability from "trace2-sid" to "session-id"
> * Noted (lack of) session ID structure in capability docs
> * Advertise SID regardless of whether trace2 is enabled
> * Simplify conditionals
> * Style cleanups
>
> Changes since V1:
> * Added a public trace2_session_id() function to trace2.{h,c}. Used this
>   in place of tr2_sid_get().
> * Fixed a style issue regarding using NULL rather than 0.

This round didn't see any responses, but it has already been extensively reviewed in the previous two rounds and looking good.

Will mark to be merged to 'next', but please holler to stop me if needed (those in v2 review CC'ed).

Thanks.