Re: [PATCH v2 02/11] docs: new trace2.advertiseSID option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 6, 2020, 11:57 UTC
Message-ID: <nycvar.QRO.7.76.6.2011061255080.18437@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqeel7ijk0.fsf@gitster.c.googlers.com>

Hi Junio,

On Thu, 5 Nov 2020, Junio C Hamano wrote:

Show 13 quoted lines

> Josh Steadmon <steadmon@google.com> writes:
>
> > Yes this makes sense. Do you think it's worthwhile to move all the
> > session ID implementation out of trace2? Right now there are some
> > user-facing bits (environment variables for parent/child SID hierarchy)
> > that specifically mention trace2, and I believe that the repo tool is
> > using it to tie together logs produced by a single repo invocation.
>
> If somebody other than trace2 starts using session ID, or if we
> introduce a mechanism that allows a session ID assigned without
> enabling the rest of the trace2 machinery, such a separation may
> make sense at the implementation level, but until then, I do not
> think it is worth doing.

Yep, the closest we came to having another user of the session ID was Matthew DeVore's `git xl` effort, but that effort seems to have gone cold (https://lore.kernel.org/git/20200207013918.GA459@comcast.net/#r is the latest message in that thread that I could find).

Ciao, Dscho