Re: [PATCH v2 02/11] docs: new trace2.advertiseSID option

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 5, 2020, 21:24 UTC
Message-ID: <xmqqeel7ijk0.fsf@gitster.c.googlers.com>
In-Reply-To: <20201105192847.GD36751@google.com>

Josh Steadmon <steadmon@google.com> writes:

Show 5 quoted lines

> Yes this makes sense. Do you think it's worthwhile to move all the
> session ID implementation out of trace2? Right now there are some
> user-facing bits (environment variables for parent/child SID hierarchy)
> that specifically mention trace2, and I believe that the repo tool is
> using it to tie together logs produced by a single repo invocation.

If somebody other than trace2 starts using session ID, or if we introduce a mechanism that allows a session ID assigned without enabling the rest of the trace2 machinery, such a separation may make sense at the implementation level, but until then, I do not think it is worth doing.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.