Re: [PATCH 00/10] Advertise trace2 SID in protocol capabilities
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Nov 5, 2020, 21:01 UTC
- Message-ID
- <f7dfc2ee-673f-8386-299c-ddfbe984b04f@jeffhostetler.com>
- In-Reply-To
- <xmqqa6vyqgoc.fsf@gitster.c.googlers.com>
On 11/3/20 4:22 PM, Junio C Hamano wrote:
Show 15 quoted lines
> Josh Steadmon <steadmon@google.com> writes: > >>> So the value being passed between client and server over the >>> protocol may look like `<sid1>/<sid2>/<sid3>` rather than just a >>> single `<sid_x>` term. For your purposes, do you want or care if >>> you get the single term or the full SID ? >> >> I'm not sure we care too much one way or the other. A single component >> of the SID should be enough to join client & server logs, but it's >> easier to just send the whole thing. > > It may be worth documenting this design decision in the protocol > doc; even though protocol doc may say this should be treated as an > opaque token, people may assume certain structure. >
good point. let me make a note to revisit that text.
thanks Jeff