Re: [PATCH v4] upload-pack.c: fix filter spec quoting bug

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2021, 21:58 UTC
Message-ID: <xmqqpn1ovi4j.fsf@gitster.c.googlers.com>
In-Reply-To: <CADMWQoPgscKm2wVOo4uEqSSwgrZQTp7_eoMJpG=pdDmc1bJr=g@mail.gmail.com>

Jacob Vosmaer <jacob@gitlab.com> writes:

> As a reader looking at t5544, unless I know the backstory of the bug,
> I do not understand why --filter gets a test but those other things do
> not.

Good point. Perhaps a retitle of the test or a bit of comment would benefit future readers.

# git clone internally has to invoke upload-pack on the
# other end with multiple arguments, and it used to quote
# them incorrectly only when hooks are enabled.
test_expect_success 'hook works with partial clone' '
	clear_hook_results &&
	test_config_global uploadpack.packObjectsHook ./hook &&
	test_config_global uploadpack.allowFilter true &&

	git clone --bare --no-local --filter=blob:none . dst.git &&
	git -C dst.git rev-list --objects --missing=print HEAD >objects &&
	grep "^?" objects
'

But that may be overkill. Those curious can run "git blame" to go back to what you wrote in the log message, and that should be clear enough for them why we care about this case.

And from that point of view, it may be sufficient that the resulting repository lacks "some" objects and not necessarily check what are missing.

Thanks.