Re: [PATCH v5 0/1] upload-pack.c: fix filter spec quoting bug

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2021, 05:49 UTC
Message-ID: <xmqq8s87hvd7.fsf@gitster.c.googlers.com>
In-Reply-To: <20210201202938.39576-1-jacob@gitlab.com>

Jacob Vosmaer <jacob@gitlab.com> writes:

> I updated the test based on the latest round of feedback.

Thanks, but this came a bit too late to wholesale replace the patch; the previous round was good enough and is in 'next' already.

Looking at the change between two versions, I guess that the change in tests may be worth salvaging, so perhaps you can make it into an incremental "the test we added earlier was good, but let's make it even better by doing X and Y" patch to be applied on top?

Thanks.

Show 6 quoted lines

> Jacob Vosmaer (1):
>   upload-pack.c: fix filter spec quoting bug
>
>  t/t5544-pack-objects-hook.sh | 10 ++++++++++
>  upload-pack.c                |  9 +--------
>  2 files changed, 11 insertions(+), 8 deletions(-)