Re: [PATCH v3 1/1] upload-pack.c: fix filter spec quoting bug

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2021, 17:51 UTC
Message-ID: <xmqqlfcf37tk.fsf@gitster.c.googlers.com>
In-Reply-To: <874kj46mwf.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 22 quoted lines

> On Tue, Jan 26 2021, Jacob Vosmaer wrote:
>
>> This fixes a bug that occurs when you combine partial clone and
>> uploadpack.packobjectshook. You can reproduce it as follows:
>
> Let's: 
>
>  * Refer to the commit we're fixing a bug in, i.e. Junio's mention of
>    10ac85c7 (upload-pack: add object filtering for partial clone,
>    2017-12-08) upthread.
>
>  * See also "imperative-mood" in SubmittingPatches. I.e. say "Fix a bug
>    in ..." not "This fixes ... can be reproduced as"
>
>  * uploadpack.packObjectsHook not uploadpack.packobjectshook except in C
>    code.
>
> ... [jc: all the helpful hints snipped] ...
>
> Thanks for hacking this up! Hopefully the above is helpful and not too
> nitpicky. Mainly wanted to help you get future patches through more
> easily...

Yeah, thanks, both, for aiming higher ;-)

I have to admit that I did find the log message a bit lacking, and that was why I had to dig bit to find out how the historical issue happened myself in the first place, and I tend to agree that it feels a bit of waste for that work to end up buried in the list archive without getting reflected in the proposed log message.