Re: [PATCH v2] upload-pack.c: fix filter spec quoting bug
On Mon, Jan 25, 2021 at 11:48:07AM -0800, Junio C Hamano wrote:
Show 7 quoted lines
> I suspect that 0b6069fe (fetch-pack: test support excluding large
> blobs, 2017-12-08) sort-of fixed half of the problem (i.e. the half
> when there is no hook used) while leaving the other half still
> broken as before.
>
> But because .use_shell does not affect if we should or should not
> quote, we can unconditionally drop the use of sq_quote_buf().
Yep. That was the same conclusion I came to in my earlier reply:
https://lore.kernel.org/git/YAs2RMT1rEH%2F2LSp@coredump.intra.peff.net/
Show 5 quoted lines
> > This commit removes the conditional quoting and adds a test for
> > partial clone in t5544.
> > ---
>
> Thanks. Missing sign-off.
Aside from the sign-off issue, this version looks good to me.
-Peff
Jeff King <peff@peff.net>