Re: [PATCH 04/11] reset_head(): remove action parameter

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2021, 20:58 UTC
Message-ID: <xmqqpmso5uno.fsf@gitster.g>
In-Reply-To: <fbaf64d6b282730f91b16ea7d5844fb0e8d779da.1633082702.git.gitgitgadget@gmail.com>

"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> The action parameter is passed as the command name to
> setup_unpack_trees_porcelain(). All but two cases pass either
> "checkout" or "reset". The case that passes "reset --hard" should be
> passing "reset" instead.

Describe how the parameter is meant to be used (presumably "this is to record in the reflog", perhaps?); without such explanation, it is hard to either agree or disagree with the claim that "reset --hard" should be "reset".

Also state if this change is supposed to have any externally observable effect.

Perhaps this improves what is shown in an error message by affecting what setup_unpack_trees_porcelain() does? I am just guessing, because the proposed log message is not telling. Please do not make me (or other readers of "git log") guess.

Thanks.