Re: [PATCH 08/11] reset_head(): take struct rebase_head_opts

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 1, 2021, 21:11 UTC
Message-ID: <xmqq8rzc5u2j.fsf@gitster.g>
In-Reply-To: <267e074e6dbd3c7cf733cd5ba4fa476d2d5e6fd2.1633082702.git.gitgitgadget@gmail.com>

"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> This function already takes a confusingly large number of parameters
> some of which are optional or not always required. The following
> commits will add a couple more parameters so change it to take a
> struct of options first.

Would all the members in the struct always be used by the function? If not, such a change will *not* solve the "confusingly ... required" problem at all.

I am not necessarily against a change to consolidate a bag of parameters into a pointer to a struct. I am against a change that is justified with a benefit that the change does not bring to us.

Thanks.