Re: [PATCH v2 00/14] rebase: reset_head() related fixes and improvements

From: Elijah Newren <newren@gmail.com>
Date: Dec 11, 2021, 11:05 UTC
Message-ID: <CABPp-BFopbtU7uNmf_7Y7rR3o7iZKt2JL8hX8k9HfCLjTVAxJA@mail.gmail.com>
In-Reply-To: <pull.1049.v2.git.1638975481.gitgitgadget@gmail.com>

On Wed, Dec 8, 2021 at 6:58 AM Phillip Wood via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 22 quoted lines

>
> Thanks for the comments on V1. I have tried to improve the commit messages
> to explain better the motivation and implications of the changes in this
> series and I have added some more tests. I have rebased onto v2.34.0 to
> avoid some merges conflicts.
>
> Changes since V1:
>
>  * Patch 1 - unchanged.
>  * Patches 2, 3 - these are new and fix an bug I noticed while adding a test
>    to patch 4.
>  * Patches 4, 5 - improved commit messages and added tests.
>  * Patch 6 - reworded commit message.
>  * Patch 7 - split out some changes that used to be in patch 9.
>  * Patch 8 - in principle the same but the range-diff is noisy due to the
>    addition of patch 3.
>  * Patch 9 - reworded commit message.
>  * Patch 10 - unchanged.
>  * Patch 11 - reworded commit message and a couple of comments.
>  * Patch 12 - minor changes to comments.
>  * Patch 13 - cosmetic changes to commit message and tests.
>  * Patch 14 - cosmetic changes to commit message.

I don't know why, but I seem to have gotten interrupted a lot more reviewing this series than others; I've come back to it multiple times. Most of the stuff I found had already been noted by Junio; the only new thing was some tiny grammatical comments I left on the commit message in Patch 13.

Overall, the series looks very nice; thanks for working on this.