Re: [PATCH] send-email: move validation code below process_address_list

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2023, 13:04 UTC
Message-ID: <xmqqpm10p67k.fsf@gitster.g>
In-Reply-To: <20231025074317.r3sydthautjjsf5y@pengutronix.de>

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:

Show 10 quoted lines

>> This fixes email address validation errors when the optional
>> perl module Email::Valid is installed and multiple addresses are passed
>> in on a single to/cc argument like --to=foo@example.com,bar@example.com.
>> 
>> Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
>> Signed-off-by: Michael Strawbridge <michael.strawbridge@amd.com>
>
> If you do Fixes: trailers as the kernel does, this could get:
>
> Fixes: a8022c5f7b67 ("send-email: expose header information to git-send-email's sendemail-validate hook")

While referring to a concrete commit object name is great, we tend not to use that particular trailer in this project; rather, we prefer to see description on how and in what way the culprit change was undesirable.

> I tested this patch on top of main (2e8e77cbac8a) and it fixes the
> regression I reported in a separate thread (where Jeff pointed out this
> patch as fixing it).

Great.  Thanks.