Re: [PATCH] send-email: move validation code below process_address_list

From: Michael Strawbridge <michael.strawbridge@amd.com>
Date: Oct 25, 2023, 18:48 UTC
Message-ID: <0bea6645-b21f-499d-bfe0-dc6ac56814fa@amd.com>
In-Reply-To: <xmqqil6v3cgq.fsf@gitster.g>

On 10/24/23 18:03, Junio C Hamano wrote:

Show 16 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> Michael Strawbridge <michael.strawbridge@amd.com> writes:
>>
>>> Subject: [PATCH] send-email: move validation code below process_address_list
>>>
>>> Move validation logic below processing of email address lists so that
>>> email validation gets the proper email addresses.
>>
>> Hmph, without this patch, the tip of 'seen' passes t9001 on my box,
>> but with it, it claims that it failed 58, 87, and 89.
> 
> FWIW, when this patch is used with 'master' (not 'seen'), t9001
> claims the same three tests failed.  The way #58 fails seems to be
> identical to the way 'seen' with this patch failed, shown in the
> message I am responding to.

I'm sorry to have wasted your time with patch 1. I had done the other manual tests but ended up forgetting the automated ones.