Re: [REGRESSION] uninitialized value $address in git send-email when given multiple recipients separated by commas

From: Jeff King <peff@peff.net>
Date: Sep 24, 2023, 03:36 UTC
Message-ID: <20230924033625.GA1492190@coredump.intra.peff.net>
In-Reply-To: <ZQ1eGzqfyoeeTBUq@debian.me>

On Fri, Sep 22, 2023 at 04:27:55PM +0700, Bagas Sanjaya wrote:

> To reproduce this regression:

I couldn't reproduce the problem here.

I had to modify your instructions slightly:

Show 13 quoted lines

> 1. Clone git.git repo, then branch off:
> 
>    ```
>    $ git clone https://github.com/git/git.git && cd git
>    $ git checkout -b test
>    ```
> 
> 2. Make two dummy signed-off commits:
> 
>    ```
>    $ echo test > test && git add test && git commit -s -m "test"
>    $ echo "test test" >> test && git commit -a -s -m "test test"
>    ```

This all worked.

Show 6 quoted lines

> 3. Generate patch series:
> 
>    ```
>    $ mkdir /tmp/test
>    $ git format-patch -o /tmp/test --cover-letter main
>    ```

This should be s/main/master/, since the git.git repo from step 1 does not have a "main" branch.

Show 5 quoted lines

> 4. Send the series to dummy address:
> 
>    ```
>    $ git send-email --to="foo <foo@acme.com>,bar <bar@acme.com>" /tmp/test/*.patch
>    ```

This did not produce an error for me. I switched out acme.com for some addresses I control, and confirmed that the mail was all delivered fine.

Your report also mentions a validation hook, so I tried installing one like:

	cat >.git/hooks/sendemail-validate <<-\EOF
	#!/bin/sh
	echo >&2 running validate hook
	exit 0
	EOF
	chmod +x .git/hooks/sendemail-validate

and confirmed that the hook runs (three times, as expected). But still no error. I'm using v2.41.0 to test against.

-Peff