Re: [PATCH] send-email: move validation code below process_address_list

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Oct 25, 2023, 07:43 UTC
Message-ID: <20231025074317.r3sydthautjjsf5y@pengutronix.de>
In-Reply-To: <ee56c4df-e030-45f9-86a9-94fb3540db60@amd.com>

Hello,

On Tue, Oct 24, 2023 at 04:19:43PM -0400, Michael Strawbridge wrote:

Show 14 quoted lines

> >From 09ea51d63cebdf9ff0c073ef86e21b4b09c268e5 Mon Sep 17 00:00:00 2001
> From: Michael Strawbridge <michael.strawbridge@amd.com>
> Date: Wed, 11 Oct 2023 16:13:13 -0400
> Subject: [PATCH] send-email: move validation code below process_address_list
> 
> Move validation logic below processing of email address lists so that
> email validation gets the proper email addresses.
> 
> This fixes email address validation errors when the optional
> perl module Email::Valid is installed and multiple addresses are passed
> in on a single to/cc argument like --to=foo@example.com,bar@example.com.
> 
> Reported-by: Bagas Sanjaya <bagasdotme@gmail.com>
> Signed-off-by: Michael Strawbridge <michael.strawbridge@amd.com>

If you do Fixes: trailers as the kernel does, this could get:

Fixes: a8022c5f7b67 ("send-email: expose header information to git-send-email's sendemail-validate hook")

I tested this patch on top of main (2e8e77cbac8a) and it fixes the regression I reported in a separate thread (where Jeff pointed out this patch as fixing it).

Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |