git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/2] git-merge-file doc: drop "-file" from argument placeholders

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 2, 2023, 16:28 UTC
Message-ID
<xmqqpm0sm85o.fsf@gitster.g>
In-Reply-To
<CAN0heSrv7MPcEwkq4uEtv9uBbqm4FLKQLE3gdsEbqKkxPXOj5A@mail.gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
> Maybe you having a similar reaction a second time makes this smell a bit
> more?

Not at all. I am perfectly OK with --object-*, not --blob-*, as the end-user facing option name. I however strongly prefer to see our log messages record the thought behind the design accurately in order to help future developers when they wonder what our intention was back when the commit was created.

In this case, I want to see that we tell our future selves "even though we named the option 'object', we plan to support blobs and nothing else, at least for now".

Thanks.
Previous: Martin ÅgrenNext: brian m. carlson
Message 31 of 34 in “Object ID support for git merge-file”
  1. 0/1 Object ID support for git merge-filebrian m. carlson, Oct 24, 2023
  2. 1/1 merge-file: add an option to process object IDsbrian m. carlson, Oct 24, 2023
  3. Eric SunshineOct 24, 2023
  4. brian m. carlsonOct 24, 2023
  5. Elijah NewrenOct 29, 2023
  6. Phillip WoodOct 29, 2023
  7. brian m. carlsonOct 30, 2023
  8. brian m. carlsonOct 29, 2023
  9. Elijah NewrenOct 30, 2023
  10. Elijah NewrenOct 29, 2023
  11. Phillip WoodOct 29, 2023
  12. Taylor BlauOct 30, 2023
  13. brian m. carlsonOct 30, 2023
  14. Elijah NewrenOct 30, 2023
  15. 0/1 Object ID support for git merge-filebrian m. carlson, Oct 30, 2023
  16. 1/1 merge-file: add an option to process object IDsbrian m. carlson, Oct 30, 2023
  17. Martin ÅgrenOct 31, 2023
  18. brian m. carlsonOct 31, 2023
  19. Junio C HamanoNov 1, 2023
  20. brian m. carlsonNov 1, 2023
  21. Elijah NewrenOct 30, 2023
  22. Junio C HamanoOct 31, 2023
  23. Phillip WoodOct 31, 2023
  24. Junio C HamanoOct 31, 2023
  25. 0/2 Object ID support for git merge-filebrian m. carlson, Nov 1, 2023
  26. 1/2 git-merge-file doc: drop "-file" from argument placeholdersbrian m. carlson, Nov 1, 2023
  27. Junio C HamanoNov 1, 2023
  28. Martin ÅgrenNov 2, 2023
  29. brian m. carlsonNov 2, 2023
  30. Martin ÅgrenNov 2, 2023
  31. Junio C HamanoNov 2, 2023
  32. 2/2 merge-file: add an option to process object IDsbrian m. carlson, Nov 1, 2023
  33. Martin ÅgrenNov 2, 2023
  34. Junio C HamanoNov 1, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.