Re: [PATCH 1/1] merge-file: add an option to process object IDs
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Oct 29, 2023, 10:12 UTC
- Message-ID
- <fec21bbe-46da-4f1c-a9b8-6be44403d68f@gmail.com>
- In-Reply-To
- <CABPp-BG9Y6aZ+TWdkL4QE9e12fu3n61V16G6DLtawEDe=g9F4w@mail.gmail.com>
Hi brian
I agree with everything Elijah said, I just have one more comment
Show 8 quoted lines
>> @@ -80,12 +88,21 @@ int cmd_merge_file(int argc, const char **argv, const char *prefix)
>>
>> fname = prefix_filename(prefix, argv[i]);
>>
>> - if (read_mmfile(mmf, fname))
>> + if (object_id) {
>> + if (repo_get_oid(the_repository, argv[i], &oid))
>> + ret = -1;It would be nice to print an error message here
ret = error("object '%s' does not exist", argv[i]);none of the existing error messages are marked for translation so I've left this untranslated as well.
Best Wishes
Phillip