Re: [PATCH v2 0/1] Object ID support for git merge-file
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 31, 2023, 23:06 UTC
- Message-ID
- <xmqqo7ge2xzl.fsf@gitster.g>
- In-Reply-To
- <6a8f3a6c-c3b0-4aff-ab36-be980ec6bbe0@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 5 quoted lines
> Hi brian > > Thanks for the re-roll, this version looks good to me > > Phillip
Yup, competently done.
I briefly thought about suggesting --blob-id instead of --object-id simply because you'd never want to feed it trees and commits, but the error message from read_mmblob() the users would get mentions 'blob' to signal that non-blob objects are unwelcome, so the name of the optionwould be OK as-is.
Queued. Let's mark it for 'next'. Thanks.