git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/7] cherry-pick: add `--empty` for more robust redundant commit handling

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 26, 2024, 18:28 UTC
Message-ID
<xmqqplvgalud.fsf@gitster.g>
In-Reply-To
<a397f3dd-e4e1-4275-b17d-1daca9e166fe@gmail.com>
phillip.wood123@gmail.com writes:
Show 13 quoted lines
> Hi Brian
> ...
>>       +		head_commit = lookup_commit(r, &head_oid);
>
> This version is definitely more readable, thanks
>
>...
>
> This looks strange, but if I do a range-diff locally from v4 to v5 I
> only see the line wrapping changes above so I don't think it is
> anything to worry about.
>
> Thanks for working on this

So, I take it as an Ack from the person who acted as the main reviewer for this series? If so, I'll mark the topic for 'next'.

Tanks, both of you.  The resulting series does look very good.
Previous: phillip.wood123@gmail.comNext: phillip.wood123@gmail.com
Message 110 of 118 in “sequencer: Do not require `allow_empty` for redundant commit options”
  1. 1/4 sequencer: Do not require `allow_empty` for redundant commit optionsbrianmlyles@gmail.com, Jan 19, 2024
  2. 2/4 docs: Clean up `--empty` formatting in `git-rebase` and `git-am`brianmlyles@gmail.com, Jan 19, 2024
  3. Phillip WoodJan 23, 2024
  4. Brian LylesJan 27, 2024
  5. Phillip WoodFeb 1, 2024
  6. 3/4 rebase: Update `--empty=ask` to `--empty=drop`brianmlyles@gmail.com, Jan 19, 2024
  7. Phillip WoodJan 23, 2024
  8. Brian LylesJan 27, 2024
  9. Phillip WoodFeb 1, 2024
  10. 4/4 cherry-pick: Add `--empty` for more robust redundant commit handlingbrianmlyles@gmail.com, Jan 19, 2024
  11. Kristoffer HaugsbakkJan 20, 2024
  12. Brian LylesJan 21, 2024
  13. Kristoffer HaugsbakkJan 21, 2024
  14. Junio C HamanoJan 21, 2024
  15. Phillip WoodJan 22, 2024
  16. Kristoffer HaugsbakkJan 22, 2024
  17. Brian LylesJan 23, 2024
  18. Kristoffer HaugsbakkJan 23, 2024
  19. Junio C HamanoJan 23, 2024
  20. Subject: [PATCH] CoC: whitespace fixJunio C Hamano, Jan 23, 2024
  21. Elijah NewrenJan 24, 2024
  22. Junio C HamanoJan 23, 2024
  23. Phillip WoodJan 23, 2024
  24. Junio C HamanoJan 23, 2024
  25. Brian LylesJan 28, 2024
  26. Brian LylesJan 27, 2024
  27. Kristoffer HaugsbakkJan 20, 2024
  28. Brian LylesJan 21, 2024
  29. Phillip WoodJan 23, 2024
  30. Junio C HamanoJan 23, 2024
  31. Phillip WoodJan 24, 2024
  32. Phillip WoodJan 24, 2024
  33. Brian LylesJan 27, 2024
  34. Brian LylesJan 28, 2024
  35. Phillip WoodJan 29, 2024
  36. Brian LylesFeb 10, 2024
  37. Phillip WoodFeb 1, 2024
  38. Brian LylesFeb 10, 2024
  39. 0/8 cherry-pick: add `--empty`Brian Lyles, Feb 10, 2024
  40. phillip.wood123@gmail.comFeb 22, 2024
  41. 1/8 docs: address inaccurate `--empty` default with `--exec`Brian Lyles, Feb 10, 2024
  42. 2/8 docs: clean up `--empty` formatting in git-rebase(1) and git-am(1)Brian Lyles, Feb 10, 2024
  43. 3/8 rebase: update `--empty=ask` to `--empty=drop`Brian Lyles, Feb 10, 2024
  44. Brian LylesFeb 11, 2024
  45. Phillip WoodFeb 14, 2024
  46. phillip.wood123@gmail.comFeb 22, 2024
  47. Junio C HamanoFeb 22, 2024
  48. 4/8 sequencer: treat error reading HEAD as unborn branchBrian Lyles, Feb 10, 2024
  49. phillip.wood123@gmail.comFeb 22, 2024
  50. Brian LylesFeb 23, 2024
  51. phillip.wood123@gmail.comFeb 25, 2024
  52. 5/8 sequencer: do not require `allow_empty` for redundant commit optionsBrian Lyles, Feb 10, 2024
  53. phillip.wood123@gmail.comFeb 22, 2024
  54. 6/8 cherry-pick: decouple `--allow-empty` and `--keep-redundant-commits`Brian Lyles, Feb 10, 2024
  55. Phillip WoodFeb 22, 2024
  56. Junio C HamanoFeb 22, 2024
  57. 7/8 cherry-pick: enforce `--keep-redundant-commits` incompatibilityBrian Lyles, Feb 10, 2024
  58. Phillip WoodFeb 22, 2024
  59. Brian LylesFeb 23, 2024
  60. Junio C HamanoFeb 23, 2024
  61. phillip.wood123@gmail.comFeb 25, 2024
  62. Brian LylesFeb 26, 2024
  63. 8/8 cherry-pick: add `--empty` for more robust redundant commit handlingBrian Lyles, Feb 10, 2024
  64. Jean-Noël AVILAFeb 11, 2024
  65. Brian LylesFeb 12, 2024
  66. phillip.wood123@gmail.comFeb 22, 2024
  67. Brian LylesFeb 23, 2024
  68. phillip.wood123@gmail.comFeb 25, 2024
  69. Brian LylesFeb 26, 2024
  70. Brian LylesFeb 26, 2024
  71. phillip.wood123@gmail.comFeb 27, 2024
  72. Junio C HamanoFeb 27, 2024
  73. 0/7 cherry-pick: add `--empty` for more robust redundant commit handlingBrian Lyles, Mar 10, 2024
  74. phillip.wood123@gmail.comMar 13, 2024
  75. 1/7 docs: address inaccurate `--empty` default with `--exec`Brian Lyles, Mar 10, 2024
  76. 2/7 docs: clean up `--empty` formatting in git-rebase(1) and git-am(1)Brian Lyles, Mar 10, 2024
  77. 3/7 rebase: update `--empty=ask` to `--empty=stop`Brian Lyles, Mar 10, 2024
  78. 4/7 sequencer: treat error reading HEAD as unborn branchBrian Lyles, Mar 10, 2024
  79. Junio C HamanoMar 11, 2024
  80. Junio C HamanoMar 11, 2024
  81. Brian LylesMar 12, 2024
  82. Junio C HamanoMar 12, 2024
  83. Brian LylesMar 16, 2024
  84. phillip.wood123@gmail.comMar 13, 2024
  85. Brian LylesMar 16, 2024
  86. 5/7 sequencer: do not require `allow_empty` for redundant commit optionsBrian Lyles, Mar 10, 2024
  87. 6/7 cherry-pick: enforce `--keep-redundant-commits` incompatibilityBrian Lyles, Mar 10, 2024
  88. 7/7 cherry-pick: add `--empty` for more robust redundant commit handlingBrian Lyles, Mar 10, 2024
  89. phillip.wood123@gmail.comMar 13, 2024
  90. Junio C HamanoMar 13, 2024
  91. Brian LylesMar 16, 2024
  92. phillip.wood123@gmail.comMar 20, 2024
  93. 0/7 cherry-pick: add `--empty` for more robust redundant commit handlingBrian Lyles, Mar 20, 2024
  94. phillip.wood123@gmail.comMar 25, 2024
  95. Brian LylesMar 25, 2024
  96. phillip.wood123@gmail.comMar 25, 2024
  97. Junio C HamanoMar 25, 2024
  98. 1/7 docs: address inaccurate `--empty` default with `--exec`Brian Lyles, Mar 20, 2024
  99. 2/7 docs: clean up `--empty` formatting in git-rebase(1) and git-am(1)Brian Lyles, Mar 20, 2024
  100. 3/7 rebase: update `--empty=ask` to `--empty=stop`Brian Lyles, Mar 20, 2024
  101. 4/7 sequencer: handle unborn branch with `--allow-empty`Brian Lyles, Mar 20, 2024
  102. Dirk GoudersMar 21, 2024
  103. Junio C HamanoMar 21, 2024
  104. Dirk GoudersMar 21, 2024
  105. 5/7 sequencer: do not require `allow_empty` for redundant commit optionsBrian Lyles, Mar 20, 2024
  106. 6/7 cherry-pick: enforce `--keep-redundant-commits` incompatibilityBrian Lyles, Mar 20, 2024
  107. 7/7 cherry-pick: add `--empty` for more robust redundant commit handlingBrian Lyles, Mar 20, 2024
  108. 0/7 cherry-pick: add `--empty` for more robust redundant commit handlingBrian Lyles, Mar 25, 2024
  109. phillip.wood123@gmail.comMar 26, 2024
  110. Junio C HamanoMar 26, 2024
  111. phillip.wood123@gmail.comMar 27, 2024
  112. 1/7 docs: address inaccurate `--empty` default with `--exec`Brian Lyles, Mar 25, 2024
  113. 2/7 docs: clean up `--empty` formatting in git-rebase(1) and git-am(1)Brian Lyles, Mar 25, 2024
  114. 3/7 rebase: update `--empty=ask` to `--empty=stop`Brian Lyles, Mar 25, 2024
  115. 4/7 sequencer: handle unborn branch with `--allow-empty`Brian Lyles, Mar 25, 2024
  116. 5/7 sequencer: do not require `allow_empty` for redundant commit optionsBrian Lyles, Mar 25, 2024
  117. 6/7 cherry-pick: enforce `--keep-redundant-commits` incompatibilityBrian Lyles, Mar 25, 2024
  118. 7/7 cherry-pick: add `--empty` for more robust redundant commit handlingBrian Lyles, Mar 25, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.