Re: [PATCH v2 8/8] cherry-pick: add `--empty` for more robust redundant commit handling

From: Brian Lyles <brianmlyles@gmail.com>
Date: Feb 26, 2024, 02:21 UTC
Message-ID: <17b748518feffc50.70b1dd9aae081c6e.203dcd72f6563036@zivdesk>
In-Reply-To: <83070e02-8e6b-43d2-819d-2272fe895c75@gmail.com>

Hi Phillip

On Sun, Feb 25, 2024 at 10:57 AM <phillip.wood123@gmail.com> wrote:

Show 7 quoted lines

>> How concerned are you about the current implementation? Does it make
>> sense to you to defer this suggestion to a future series that cleans up
>> the tests to do more user-oriented checks?
> 
> I think adding tests that follow a pattern we want to change is just 
> storing up work for the future and makes it less likely we'll improve 
> things because it will be more work to do so.

That's fair. I'll rework these in v3. Thanks!

-- 
Thank you,
Brian Lyles

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.