Re: [PATCH 4/4] cherry-pick: Add `--empty` for more robust redundant commit handling

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Jan 23, 2024, 07:11 UTC
Message-ID: <6475ad33-423e-43ef-aa75-3ff5539a04d1@app.fastmail.com>
In-Reply-To: <CAHPHrSd8rLj_TDE11dYQW+51--8YC4rumnfT+v2bYr+K7AMQrQ@mail.gmail.com>

On Tue, Jan 23, 2024, at 06:23, Brian Lyles wrote:

Show 11 quoted lines

>> Oh, and this thread reminded me https://lore.kernel.org/git/xmqqle8hrtcs.fsf@gitster.g/T/#t
>>
>> that editorconfig[1] has this option:
>>
>> ```
>> trim_trailing_whitespace = true
>> ```
>> […]
>
> Is there a good reason that this should not just be added to the
> `.editorconfig` in this repository? Would a patch for this be welcome?

I was thinking the same thing when I saw that other thread. It doesn’t hurt to try.

I was also curious about some subtleties like: does it dictate enforcing this for all the lines of a touched files or only the modified ones? Because the latter is much more useful.

-- 
Kristoffer Haugsbakk