Re: [PATCH v3] http: do not ignore proxy path
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 1, 2024, 05:21 UTC
- Message-ID
- <xmqqplqsyg1i.fsf@gitster.g>
- In-Reply-To
- <9ffa9bf5-f799-400f-5e45-ccbc5316ee42@alum.mit.edu>
Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> writes:
Show 5 quoted lines
>> We insist that it must be "localhost", so let's not do strcasecmp() >> but just do strcmp(). > > I don't see the wisdom of being more restrictive than curl is in this > respect.
Ah, if curl is doing case insensitivity, then matching its behaviour is perfectly fine. I was just reacting to this message ...
> + die("Invalid proxy URL '%s': host must be localhost if a path is present",... that results when strcasecmp() does not like it.
Thanks.