Re: [PATCH] http: do not ignore proxy path

From: Jeff King <peff@peff.net>
Date: Jul 29, 2024, 19:31 UTC
Message-ID: <20240729193113.GA23714@coredump.intra.peff.net>
In-Reply-To: <4f962eaa-d12b-d250-dd93-a1673af850c6@alum.mit.edu>

On Fri, Jul 26, 2024 at 06:43:29PM -0400, Ryan Hendrickson wrote:

Show 7 quoted lines

> > I wonder if we could go back to passing the string straight to curl (as
> > we did prior to 2016), and keeping the proxy_auth struct purely as a
> > mechanism for gathering credentials.
> 
> Hmm, that would be nice, but I think curl doesn't deal well with the extra
> case that Git supports of specifying a username but no password. It causes
> one of the existing tests to fail if I pass the string straight through.

OK, thanks for trying. It would have been nice, but I'm not surprised that there's an unusual interaction.

Show 8 quoted lines

> On top of that, all of those starts_with tests for checking the protocol are
> written quite loosely, so in practice Git "supports" the protocols
> "socks://" and "socksonmyfeet://" by mapping them both to SOCKS4, and curl
> would not like it if it received those strings directly.
>
> So given that Git wants to handle the protocol and the credentials, it makes
> sense that only the host and the path are passed to curl. I just have to
> make sure that they are correctly re-encoded.

Makes sense.

-Peff