Re: [PATCH v5] http: do not ignore proxy path

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2024, 21:13 UTC
Message-ID: <xmqqfrrmbpbv.fsf@gitster.g>
In-Reply-To: <30733887-33d8-4049-7dc9-8bc9d0b106da@alum.mit.edu>

Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> writes:

Show 16 quoted lines

> At 2024-08-02 12:28-0700, Junio C Hamano <gitster@pobox.com> sent:
>
>>>>> Is this blocking feedback? This strikes me as speculative
>>>>> over-engineering
>>>>
>>>> No, it is loosening a pattern that is overly tight and as a side
>>>> effect shortening the line to more readable length ;-).
>>>
>>> Blocking or not?
>>
>> If we are updating anyway, that question is irrelevant, no?  This
>> version may hit 'seen' but until the next version comes it will not
>> advance to 'next'.
>
> I can't figure out what you mean by this so I am going to proceed as
> if you had simply said ‘non-blocking’.

It does not make much sense to ask if a suggestion is "blocking" or "non-blocking". If you respond with a reasonable explanation why you do not want to take a suggestion, I may (or may not) say that your reasoning makes sense. IOW, making me say "it is blocking" means you want to me to say that I won't listen to you no matter what you say. That is rarely be the case.

In this case, I do not think it makes sense to insist with -Fx that the error message has the exact message. And I do not think your "strikes me as" qualifies as a "reasonable explanation".