Re: [PATCH v5] http: do not ignore proxy path
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 2, 2024, 21:47 UTC
- Message-ID
- <xmqqikwia97c.fsf@gitster.g>
- In-Reply-To
- <c7b3383b-ebbf-6ec4-00b8-41c9430a99f4@alum.mit.edu>
Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> writes:
> what the test matches against. Matching against hypothetical future > errors is speculative overengineering if it is not obvious how the > errors will vary and what it may mean if they do.
The easiest you can imagine is that it turns out the cut-off version of cURL for the feature turned out to be not 7.84, or versions of cURL shipped by some distros have backports of the feature to an older version that explicitly naming 7.84 causes more confusion than naming the exact feature we rely on, and we end up rephrasing the error message. We have done such changes in the past, so it is not really speculating "hypothetical future errors", but applying common sense gained over years working on this project.