git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSOC PATCH 0/2] mailmap: reduce global state

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 19, 2026, 22:50 UTC
Message-ID
<xmqqpl601h7e.fsf@gitster.g>
In-Reply-To
<xmqqh5rc2zuq.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 19 quoted lines
> Burak Kaan Karaçay <bkkaracay@gmail.com> writes:
>
>> This patch series aims to reduce the global variable dependency of the
>> mailmap subsystem:
>>
>>   - Patch 1 eliminates the implicit 'the_repository' dependency in the
>>     'read_mailmap' and 'read_mailmap_blob' functions by adding a
>>     'struct repository' parameter.
>>
>>   - Patch 2 removes the 'git_mailmap_file' and 'git_mailmap_blob' global
>>     variables, shifting to on-demand configuration reading via the config
>>     set helpers and using local variables.
>
> These are surprisingly simple and straight-forward, as the final
> destination has nothing to do with any global, and not even part of
> a long-lived structure like "repo", but just a simple string_list
> mailmap.  Nicely done.
>
> Will queue.
Oops, not so fast.  "make hdr-check" catches a problem in this topic.
    mailmap.h:11:30: error: 'struct repository' declared inside parameter list will not be visible outside of this definition or
    declaration [-Werror]
Previous: Junio C HamanoNext: Burak Kaan Karaçay
Message 5 of 9 in “mailmap: reduce global state”
  1. 0/2 mailmap: reduce global stateBurak Kaan Karaçay, Feb 19, 2026
  2. 1/2 mailmap: stop using the_repositoryBurak Kaan Karaçay, Feb 19, 2026
  3. 2/2 mailmap: drop global config variablesBurak Kaan Karaçay, Feb 19, 2026
  4. Junio C HamanoFeb 19, 2026
  5. Junio C HamanoFeb 19, 2026
  6. 0/2 mailmap: reduce global stateBurak Kaan Karaçay, Feb 20, 2026
  7. 1/2 mailmap: stop using the_repositoryBurak Kaan Karaçay, Feb 20, 2026
  8. 2/2 mailmap: drop global config variablesBurak Kaan Karaçay, Feb 20, 2026
  9. Junio C HamanoFeb 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.