[GSOC PATCH v2 0/2] mailmap: reduce global state
- From
Burak Kaan Karaçay <bkkaracay@gmail.com>
- Date
- Feb 20, 2026, 06:04 UTC
- Message-ID
- <20260220060442.29469-1-bkkaracay@gmail.com>
- In-Reply-To
- <20260219125954.3539324-1-bkkaracay@gmail.com>
Hi,
This patch series aims to reduce the global variable dependency of the mailmap subsystem:
- Patch 1 eliminates the implicit 'the_repository' dependency in the
'read_mailmap' and 'read_mailmap_blob' functions by adding a
'struct repository' parameter. - Patch 2 removes the 'git_mailmap_file' and 'git_mailmap_blob' global
variables, shifting to on-demand configuration reading via the config
set helpers and using local variables.
Changes in v2:
- Forward declare 'struct repository' in mailmap.h
- Fix whitespace problemsThanks to Junio for the kind words and for catching the 'make hdr-check' issue.
Burak Kaan Karaçay (2): mailmap: stop using the_repository mailmap: drop global config variables
builtin/blame.c | 2 +- builtin/cat-file.c | 2 +- builtin/check-mailmap.c | 4 ++-- builtin/commit.c | 2 +- builtin/log.c | 2 +- builtin/shortlog.c | 2 +- environment.c | 19 ------------------- mailmap.c | 30 +++++++++++++++++++----------- mailmap.h | 9 ++++----- pretty.c | 2 +- ref-filter.c | 2 +- 11 files changed, 32 insertions(+), 44 deletions(-)
-- 2.52.0