From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Feb 2026 22:50:13 GMT
Subject: Re: [GSOC PATCH 0/2] mailmap: reduce global state
Message-ID: <xmqqpl601h7e.fsf@gitster.g>
In-Reply-To: <xmqqh5rc2zuq.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Burak Kaan Karaçay <bkkaracay@gmail.com> writes:
>
>> This patch series aims to reduce the global variable dependency of the
>> mailmap subsystem:
>>
>>   - Patch 1 eliminates the implicit 'the_repository' dependency in the
>>     'read_mailmap' and 'read_mailmap_blob' functions by adding a
>>     'struct repository' parameter.
>>
>>   - Patch 2 removes the 'git_mailmap_file' and 'git_mailmap_blob' global
>>     variables, shifting to on-demand configuration reading via the config
>>     set helpers and using local variables.
>
> These are surprisingly simple and straight-forward, as the final
> destination has nothing to do with any global, and not even part of
> a long-lived structure like "repo", but just a simple string_list
> mailmap.  Nicely done.
>
> Will queue.

Oops, not so fast.  "make hdr-check" catches a problem in this topic.

    mailmap.h:11:30: error: 'struct repository' declared inside parameter list will not be visible outside of this definition or
    declaration [-Werror]